agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use XLogRecPtrIsValid() consistently for WAL position checks
Date: Thu, 16 Apr 2026 14:03:44 +0000
Message-ID: <E1wDNJo-001G1W-0m@gemulon.postgresql.org> (raw)
Use XLogRecPtrIsValid() consistently for WAL position checks
Commit a2b02293bc6 switched various checks to use XLogRecPtrIsValid(),
but later changes reintroduced XLogRecPtrIsInvalid() and direct comparisons
with InvalidXLogRecPtr.
This commit replaces those uses with XLogRecPtrIsValid() for better
readability and consistency.
Author: Vignesh C <vignesh21@gmail.com>
Reviewed-by: Xiaopeng Wang <wxp_728@163.com>
Reviewed-by: Amul Sul <sulamul@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T=hau8UTAU0+eLQQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2fd84e2226e2e1e13f5ad57bec3465488d67e944
Modified Files
--------------
src/backend/commands/repack_worker.c | 2 +-
src/backend/replication/walreceiver.c | 4 ++--
src/bin/pg_waldump/archive_waldump.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
Message-ID: <E1wDNJo-001G1W-0m@gemulon.postgresql.org>
Permalink: ../E1wDNJo-001G1W-0m@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wDNJo-001G1W-0m@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Use XLogRecPtrIsValid() consistently for WAL position checks
In-Reply-To: <E1wDNJo-001G1W-0m@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox