agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add missing initialization
Date: Thu, 16 Apr 2026 20:31:35 +0000
Message-ID: <E1wDTN8-001Iof-1K@gemulon.postgresql.org> (raw)
Add missing initialization
The backend running REPACK can check DecodingWorkerShared->initialized
before the worker could have the chance to initialize it, possibly
leading to wrong behavior.
While at it, remove DecodingWorkerShared->worker_dsm_segment, because
that doesn't actually need to be in shared memory; a simple local-memory
global variable is enough.
Oversights in commit 28d534e2ae0a.
Author: Antonin Houska <ah@cybertec.at>
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/18181295-8375-4789-ad32-269d78d6001e@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/05c401d5786a05ea630e884ffa492aa01683d15b
Modified Files
--------------
src/backend/commands/repack.c | 1 +
src/backend/commands/repack_worker.c | 7 +++++--
src/include/commands/repack_internal.h | 1 -
3 files changed, 6 insertions(+), 3 deletions(-)
Message-ID: <E1wDTN8-001Iof-1K@gemulon.postgresql.org>
Permalink: ../E1wDTN8-001Iof-1K@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wDTN8-001Iof-1K@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@kurilemu.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add missing initialization
In-Reply-To: <E1wDTN8-001Iof-1K@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox