agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make psql DETAIL line test unconditionally optional.
Date: Thu, 16 Apr 2026 20:57:53 +0000
Message-ID: <E1wDTma-001J15-2Z@gemulon.postgresql.org> (raw)

Make psql DETAIL line test unconditionally optional.

Commit 3e2a1496bae6 made the psql TAP test require the DETAIL line on
platforms with SA_SIGINFO, rather than making it optional. This
unexpectedly blew up on OpenBSD buildfarm members, because OpenBSD does
not set si_pid for SIGTERM signals even though it has SA_SIGINFO
defined.

So revert to the test as it was in commit 55890a919454, where the detail
line being missing never causes an error.

Author: Jakub Wartak <jakub.wartak@enterprisedb.com>
Suggested-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/2007157.1776269052%40sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/446c400fd89b46ac6e71fb01604ffd830f12c9e9

Modified Files
--------------
src/bin/psql/t/001_basic.pl | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)



Message-ID: <E1wDTma-001J15-2Z@gemulon.postgresql.org>
Permalink:  ../E1wDTma-001J15-2Z@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wDTma-001J15-2Z@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Make psql DETAIL line test unconditionally optional.
  In-Reply-To: <E1wDTma-001J15-2Z@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox