agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Melanie Plageman <melanieplageman@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: bufmgr: use I/O stats arguments in FlushUnlockedBuffer()
Date: Tue, 21 Apr 2026 21:51:11 +0000
Message-ID: <E1wFIzu-0023vr-1H@gemulon.postgresql.org> (raw)

bufmgr: use I/O stats arguments in FlushUnlockedBuffer()

FlushUnlockedBuffer() accepted io_object and io_context arguments but
hardcoded IOOBJECT_RELATION and IOCONTEXT_NORMAL when calling
FlushBuffer(). Pass them through instead. Also fix FlushBuffer() to use
its io_object parameter for I/O timing stats rather than hardcoding
IOOBJECT_RELATION.

Not actively broken since all current callers pass IOOBJECT_RELATION and
IOCONTEXT_NORMAL, so not backpatched.

Author: Chao Li <lic@highgo.com>
Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://postgr.es/m/BC97546F-5C15-42F2-AD57-CFACDB9657D0@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/31b0544b32bc9e08c8c6775aed7ca2b808390f80

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



Message-ID: <E1wFIzu-0023vr-1H@gemulon.postgresql.org>
Permalink:  ../E1wFIzu-0023vr-1H@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wFIzu-0023vr-1H@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: melanieplageman@gmail.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: bufmgr: use I/O stats arguments in FlushUnlockedBuffer()
  In-Reply-To: <E1wFIzu-0023vr-1H@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox