agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Allow ALTER INDEX .. ATTACH PARTITION to validate a parent index
Date: Wed, 22 Apr 2026 01:35:22 +0000
Message-ID: <E1wFMUr-0025H7-1C@gemulon.postgresql.org> (raw)
Allow ALTER INDEX .. ATTACH PARTITION to validate a parent index
This commit tweaks ALTER INDEX .. ATTACH PARTITION to attempt a
validation of a parent index in the case where an index is already
attached but the parent is not yet valid. This occurs in cases where a
parent index was created invalid such as with CREATE INDEX ONLY, but was
left invalid after an invalid child index was attached (partitioned
indexes set indisvalid to false if at least one partition is
!indisvalid, indisvalid is true in a partitioned table iff all
partitions are indisvalid). This could leave a partition tree in a
situation where a user could not bring the parent index back to valid
after fixing the child index, as there is no built-in mechanism to do
so. This commit relies on the fact that repeated ATTACH PARTITION
commands on the same index silently succeed.
An invalid parent index is more than just a passive issue. It causes
for example ON CONFLICT on a partitioned table if the invalid parent
index is used to enforce a unique constraint.
Some test cases are added to track some of problematic patterns, using a
set of partition trees with combinations of invalid indexes and ATTACH
PARTITION.
Reported-by: Mohamed Ali <moali.pg@gmail.com>
Author: Sami Imseih <sanmimseih@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Haibo Yan <tristan.yim@gmail.com>
Discussion: http://postgr.es/m/CAGnOmWqi1D9ycBgUeOGf6mOCd2Dcf=6sKhbf4sHLs5xAcKVCMQ@mail.gmail.com
Backpatch-through: 14
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/becf6d26961aabe26facebee2604ef5def9733e5
Modified Files
--------------
src/backend/commands/tablecmds.c | 13 +++-
src/test/regress/expected/indexing.out | 105 +++++++++++++++++++++++++++++++++
src/test/regress/sql/indexing.sql | 59 ++++++++++++++++++
3 files changed, 176 insertions(+), 1 deletion(-)
view thread (6+ messages) latest in thread
Message-ID: <E1wFMUr-0025H7-1C@gemulon.postgresql.org>
Permalink: ../E1wFMUr-0025H7-1C@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wFMUr-0025H7-1C@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow ALTER INDEX .. ATTACH PARTITION to validate a parent index
In-Reply-To: <E1wFMUr-0025H7-1C@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox