agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix new-to-v19 -Wshadow warnings
Date: Thu, 23 Apr 2026 04:49:49 +0000
Message-ID: <E1wFm0b-002GKH-0e@gemulon.postgresql.org> (raw)
Fix new-to-v19 -Wshadow warnings
There's some talk about upgrading our current -Wshadow=compatible-local
up to -Wshadow. There's some pending questions as to whether the churn
and extra backpatching pain are worthwhile for doing all of them. We
can't use the latter argument for ones that are new to v19, providing we
fix them now. So let's fix those ones so that the problem is not any
worse for if we decide to fix the remainder for v20.
Author: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Peter Smith <smithpb2250@gmail.com>
Reviewed-by: Yuchen Li <liyuchen_xyz@163.com>
Discussion: https://postgr.es/m/CAApHDvp=rx5GxM=yW8QhFF3noXtYt7LkOxJ7zkaPOzpti4Gm8w@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4f0cbc6fb5df6dec84482d0bf0ff2d2d4be58132
Modified Files
--------------
src/backend/commands/tablecmds.c | 28 ++++++++++++++--------------
src/backend/commands/wait.c | 12 ++++++------
src/backend/postmaster/datachecksum_state.c | 8 ++++----
src/bin/pg_dump/pg_dumpall.c | 26 ++++++++++++--------------
src/bin/psql/describe.c | 12 ++++++------
5 files changed, 42 insertions(+), 44 deletions(-)
Message-ID: <E1wFm0b-002GKH-0e@gemulon.postgresql.org>
Permalink: ../E1wFm0b-002GKH-0e@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wFm0b-002GKH-0e@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix new-to-v19 -Wshadow warnings
In-Reply-To: <E1wFm0b-002GKH-0e@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox