agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix collation of expressions in GRAPH_TABLE COLUMNS clause
Date: Fri, 24 Apr 2026 06:49:16 +0000
Message-ID: <E1wGALj-002T7s-2U@gemulon.postgresql.org> (raw)
Fix collation of expressions in GRAPH_TABLE COLUMNS clause
GRAPH_TABLE clause is converted into a rangetable entry, which is
ignored by assign_query_collations(). Hence we assign collations
while transforming its parts. But expressions in COLUMNS clause
missed that treatment, so fix that.
While at it, also add comments about collation assignment to the parts
of GRAPH_TABLE clause, and also fix a small grammar issue.
Reported-by: Satyanarayana Narlapuram <satyanarlapuram@gmail.com>
Author: Satyanarayana Narlapuram <satyanarlapuram@gmail.com>
Author: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Discussion: https://www.postgresql.org/message-id/CAHg+QDc4aaiufYSgrwMMPMMRTPtQ66SghcrPFbWJFZMqNaG+BA@mail.gmail...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ac3bcc041c5cc2b7ce522d4ce6e6c4653f1263ea
Modified Files
--------------
src/backend/parser/parse_clause.c | 6 ++++++
src/backend/parser/parse_graphtable.c | 12 +++++++++++-
src/test/regress/expected/graph_table.out | 8 ++++----
src/test/regress/sql/graph_table.sql | 4 ++--
4 files changed, 23 insertions(+), 7 deletions(-)
Message-ID: <E1wGALj-002T7s-2U@gemulon.postgresql.org>
Permalink: ../E1wGALj-002T7s-2U@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wGALj-002T7s-2U@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix collation of expressions in GRAPH_TABLE COLUMNS clause
In-Reply-To: <E1wGALj-002T7s-2U@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox