agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix wrong datum conversion for subretentionactive in CreateSubsc
Date: Tue, 28 Apr 2026 07:49:55 +0000
Message-ID: <E1wHdCd-003Add-0p@gemulon.postgresql.org> (raw)

Fix wrong datum conversion for subretentionactive in CreateSubscription.

Use BoolGetDatum() instead of Int32GetDatum() when storing the boolean
subretentionactive column in pg_subscription. This was an oversight in
a850be2fe6.

Author: Lakshmi N <lakshmin.jhs@gmail.com>
Reviewed-by: Nisha Moond <nisha.moond412@gmail.com>
Discussion: https://postgr.es/m/CA+3i_M98-XjE-_fw0p+8xOnw64y2_YLtJfcwvCfsVMn-z2ZjGg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7424aac088e1c4356b92d2673378dbdd50d1c888

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Message-ID: <E1wHdCd-003Add-0p@gemulon.postgresql.org>
Permalink:  ../E1wHdCd-003Add-0p@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wHdCd-003Add-0p@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix wrong datum conversion for subretentionactive in CreateSubsc
  In-Reply-To: <E1wHdCd-003Add-0p@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox