agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Cosmetic fixes for radix sort
Date: Wed, 29 Apr 2026 09:15:19 +0000
Message-ID: <E1wI10p-003JIE-0T@gemulon.postgresql.org> (raw)

Cosmetic fixes for radix sort

Do minor comment fixes and remove implicit cast to Datum.

While here, let's prefer crashing instead of entering an infinite
loop in case of future programming mistakes when computing next_level,
suggested by ChangAo Chen.

Discussion: https://postgr.es/m/tencent_49E3F11E74D8A584A2144ED532A490CBC40A@qq.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ca9807dfec5b70751c3524de264e4a16afb2a94a

Modified Files
--------------
src/backend/utils/sort/tuplesort.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)



Message-ID: <E1wI10p-003JIE-0T@gemulon.postgresql.org>
Permalink:  ../E1wI10p-003JIE-0T@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wI10p-003JIE-0T@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: john.naylor@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Cosmetic fixes for radix sort
  In-Reply-To: <E1wI10p-003JIE-0T@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox