agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Prevent pg_enable/disable_data_checksums() on standby
Date: Thu, 30 Apr 2026 11:46:34 +0000
Message-ID: <E1wIPqk-003SOT-0X@gemulon.postgresql.org> (raw)
Prevent pg_enable/disable_data_checksums() on standby
These functions missed a RecoveryInProgress() check, allowing them to
be called on a hot standby. Enabling, or disabling, checksums on the
standby only would cause the cluster to get out of sync and replaying
checksum transitions to fail.
Author: Satyanarayana Narlapuram <satyanarlapuram@gmail.com>
Reviewed-by: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Reviewed-by: Tomas Vondra <tomas@vondra.me>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/CAHg+QDfRk4-S7DMmdbXJnQ-xF=sUpMAKuh8b83ObLqYVKx5QLA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b120358c612dce62b493da7682b4df90a10783c9
Modified Files
--------------
src/backend/postmaster/datachecksum_state.c | 4 ++++
1 file changed, 4 insertions(+)
Message-ID: <E1wIPqk-003SOT-0X@gemulon.postgresql.org>
Permalink: ../E1wIPqk-003SOT-0X@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wIPqk-003SOT-0X@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prevent pg_enable/disable_data_checksums() on standby
In-Reply-To: <E1wIPqk-003SOT-0X@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox