agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add timingsafe_bcmp(), for constant-time memory comparison
Date: Mon, 11 May 2026 12:19:38 +0000
Message-ID: <E1wMPbm-0002XF-16@gemulon.postgresql.org> (raw)
Add timingsafe_bcmp(), for constant-time memory comparison
timingsafe_bcmp() should be used instead of memcmp() or a naive
for-loop, when comparing passwords or secret tokens, to avoid leaking
information about the secret token by timing. This commit just
introduces the function but does not change any existing code to use
it yet.
This has been initially applied as of 09be39112654 in v18 and newer
versions, and will be used in all the stable branches for an upcoming
fix.
Co-authored-by: Jelte Fennema-Nio <github-tech@jeltef.nl>
Discussion: https://www.postgresql.org/message-id/7b86da3b-9356-4e50-aa1b-56570825e234@iki.fi
Security: CVE-2026-6478
Backpatch-through: 14
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/8e34acfda11595fdf2b1cfa96dc6949c34d34cd7
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Modified Files
--------------
configure | 23 +++++++++++++++++++++++
configure.ac | 3 ++-
meson.build | 2 ++
src/include/pg_config.h.in | 7 +++++++
src/include/port.h | 4 ++++
src/port/meson.build | 1 +
src/port/timingsafe_bcmp.c | 43 +++++++++++++++++++++++++++++++++++++++++++
7 files changed, 82 insertions(+), 1 deletion(-)
view thread (5+ messages) latest in thread
Message-ID: <E1wMPbm-0002XF-16@gemulon.postgresql.org>
Permalink: ../E1wMPbm-0002XF-16@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wMPbm-0002XF-16@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add timingsafe_bcmp(), for constant-time memory comparison
In-Reply-To: <E1wMPbm-0002XF-16@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox