agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: ecpg: Reject multiple header items in GET/SET DESCRIPTOR
Date: Mon, 08 Jun 2026 08:15:12 +0000
Message-ID: <E1wWV8a-001ZOH-39@gemulon.postgresql.org> (raw)

ecpg: Reject multiple header items in GET/SET DESCRIPTOR

Previously, ecpg accepted multiple descriptor header items in GET DESCRIPTOR
and SET DESCRIPTOR, but generated broken C code when they were used.
Although the grammar allowed this syntax, the implementation did not actually
support it.

This commit tightens the ecpg grammar so the header form of GET/SET DESCRIPTOR
accepts only a single header item, matching the implementation and preventing
generation of broken C code.

Also update the documentation synopsis accordingly.

Backpatch to all supported versions.

Author: Masashi Kamura <kamura.masashi@fujitsu.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Lakshmi G <lakshmigcdac@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/OS9PR01MB13174AD7D1829D0644B6BB90E9447A@OS9PR01MB13174.jpnprd01.prod.outlook.com
Backpatch-through: 14

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fe8c0a762b30b94868b5d197cd63115b2f1f9faf

Modified Files
--------------
doc/src/sgml/ecpg.sgml                   |  6 +++---
src/interfaces/ecpg/preproc/ecpg.trailer | 12 ++----------
2 files changed, 5 insertions(+), 13 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1wWV8a-001ZOH-39@gemulon.postgresql.org>
Permalink:  ../E1wWV8a-001ZOH-39@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wWV8a-001ZOH-39@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: ecpg: Reject multiple header items in GET/SET DESCRIPTOR
  In-Reply-To: <E1wWV8a-001ZOH-39@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox