agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Enable fast default for domains with non-volatile constr
Date: Mon, 08 Jun 2026 18:23:02 +0000
Message-ID: <E1wWeco-001dGl-11@gemulon.postgresql.org> (raw)

Revert "Enable fast default for domains with non-volatile constraints"

This reverts commit a0b6ef29a51818a4073a5f390ed10ef6453d5c11, along with
its follow-up 2e123e3c2bd34f2377212a4e7cfcdbf9e2d9c7ff ("Silence compiler
warning from older compilers"), which only adjusted code introduced by
the former.

The change failed with an empty table and an invalid default, and the
best way to deal with that will involve an addition to the TAM API, so
it's not ready for relese 19 now.

Discussion: https://postgr.es/m/7033D663-DDB4-4B35-922C-F33DE53B1502@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a0354e29c41a9fb7491b3c7c23f079b1923c045a

Modified Files
--------------
src/backend/commands/tablecmds.c           | 59 +++++++++--------------------
src/backend/executor/execExpr.c            | 35 +----------------
src/include/executor/executor.h            |  2 -
src/test/regress/expected/fast_default.out | 61 ------------------------------
src/test/regress/sql/fast_default.sql      | 51 -------------------------
5 files changed, 18 insertions(+), 190 deletions(-)



Message-ID: <E1wWeco-001dGl-11@gemulon.postgresql.org>
Permalink:  ../E1wWeco-001dGl-11@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wWeco-001dGl-11@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Revert "Enable fast default for domains with non-volatile constr
  In-Reply-To: <E1wWeco-001dGl-11@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox