agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use correct type for catalog_xmin
Date: Mon, 08 Jun 2026 23:20:02 +0000
Message-ID: <E1wWjGE-001f7Q-1x@gemulon.postgresql.org> (raw)

Use correct type for catalog_xmin

Commit 85c17f6 mistakenly declared a variable storing catalog_xmin as
XLogRecPtr, even though catalog_xmin is a TransactionId.

This caused no functional issue, but the type was clearly incorrect.
Therefore, this commit fixes it to use the correct type TransactionId
instead, and backpatch to v17 where the issue was introduced.

Author: Imran Zaheer <imran.zhir@gmail.com>
Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CA+UBfa=mNeLt-4BFjEP4tqdDsnq+oMqqPr7fd9Wji2_9YXmQdA@mail.gmail.com

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9db452c2355092ce28fb5b62b9541779ff7fe601

Modified Files
--------------
src/backend/replication/logical/slotsync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (3+ messages)

Message-ID: <E1wWjGE-001f7Q-1x@gemulon.postgresql.org>
Permalink:  ../E1wWjGE-001f7Q-1x@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wWjGE-001f7Q-1x@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Use correct type for catalog_xmin
  In-Reply-To: <E1wWjGE-001f7Q-1x@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox