agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix inconsistencies with pg_restore --statistics[-only]
Date: Mon, 15 Jun 2026 23:23:55 +0000
Message-ID: <E1wZGep-000Ter-2I@gemulon.postgresql.org> (raw)
Fix inconsistencies with pg_restore --statistics[-only]
Attempting to restore a schema, a table or an index with
--only-statistics skipped all the statistics of the objects wanted.
Like for pg_dump, statistics should be included, so this created an
assymetry between dump and restore.
A second set of problems existed for --table and --index, where the
presence of --statistics skipped the restore of the stats of the
object(s) targetted.
This issue has been reported originally as related to an inconsistency
with the way extended stats restore is handled in Postgres v19, but the
issue is related to the restore of relation and attribute statistics in
v18. Some TAP tests are added to cover all these cases.
Reported-by: Chao Li <li.evan.chao@gmail.com>
Author: Chao Li <li.evan.chao@gmail.com>
Author: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: https://postgr.es/m/66E80CAB-527C-42B1-BB65-3F82CF4AD998@gmail.com
Backpatch-through: 18
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0dd93de69e80ce98eb23f86d163bea8b0787643e
Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 36 ++++++++++++++++------
src/bin/pg_dump/t/002_pg_dump.pl | 60 ++++++++++++++++++++++++++++++++++++
2 files changed, 87 insertions(+), 9 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wZGep-000Ter-2I@gemulon.postgresql.org>
Permalink: ../E1wZGep-000Ter-2I@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wZGep-000Ter-2I@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix inconsistencies with pg_restore --statistics[-only]
In-Reply-To: <E1wZGep-000Ter-2I@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox