agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_dump: Remove dead code in TAP tests
Date: Mon, 15 Jun 2026 23:34:14 +0000
Message-ID: <E1wZGoo-000Tj5-1W@gemulon.postgresql.org> (raw)

pg_dump: Remove dead code in TAP tests

The schema_only_with_statistics test scenario was referenced in
002_pg_dump.pl, but was associated to no command sequence since
0ed92cf50cc4.

Issue discovered while investigating a different bug.  Perhaps this
cleanup is not worth backpatching, but there is also an argument in
favor of reducing noise when touching this area of the code in stable
branches.

Reviewed-by: Ewan Young <kdbase.hack@gmail.com>
Reviewed-by: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Discussion: https://postgr.es/m/ai-y0S7Z25NlrG_n@paquier.xyz
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d3b345eef3f3a08da724aa5681e3dbe6fbb1d91a

Modified Files
--------------
src/bin/pg_dump/t/002_pg_dump.pl | 22 +---------------------
1 file changed, 1 insertion(+), 21 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1wZGoo-000Tj5-1W@gemulon.postgresql.org>
Permalink:  ../E1wZGoo-000Tj5-1W@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wZGoo-000Tj5-1W@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: pg_dump: Remove dead code in TAP tests
  In-Reply-To: <E1wZGoo-000Tj5-1W@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox