agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix various query jumble comments
Date: Tue, 16 Jun 2026 01:43:35 +0000
Message-ID: <E1wZIpy-000UTM-2e@gemulon.postgresql.org> (raw)
Fix various query jumble comments
Some comments for struct WindowFunc were trying to detail which fields
were irrelevant for query jumble but the list had not been kept
up-to-date. Here we fix that by removing the comment to allow the
"query_jumble_ignore" attribute to self-document. This involved
removing similar comments from other structs.
While we're on the topic, improve comments around why Consts only jumble
the "consttype" and also add some rationale about why various other fields
are ignored.
Reported-by: jian he <jian.universality@gmail.com>
Author: David Rowley <dgrowleyml@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CACJufxEWeP2SLVMsbFNynd0pQnwbxh6U-v1nq5ccf9mSvBZntw%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e5f94c4808fe88c170840ac3a24cdfa423b404fc
Modified Files
--------------
src/include/nodes/nodes.h | 6 ++----
src/include/nodes/parsenodes.h | 29 ++++++++++++-----------------
src/include/nodes/primnodes.h | 39 ++++++++++-----------------------------
3 files changed, 24 insertions(+), 50 deletions(-)
Message-ID: <E1wZIpy-000UTM-2e@gemulon.postgresql.org>
Permalink: ../E1wZIpy-000UTM-2e@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wZIpy-000UTM-2e@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix various query jumble comments
In-Reply-To: <E1wZIpy-000UTM-2e@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox