agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Álvaro Herrera <alvherre@kurilemu.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: concurrent repack: check there are no leftover toast attribs
Date: Tue, 16 Jun 2026 12:28:39 +0000
Message-ID: <E1wZSuF-000Z3a-2D@gemulon.postgresql.org> (raw)

concurrent repack: check there are no leftover toast attribs

Upon reading attributes from the file of concurrent changes, verify that
none are left over unprocessed after we read all columns for the tuple.
This should never happen, so add an elog(ERROR) for it.

While at it, downgrade a nearby message from ereport() to elog().  These
things should never happen.

Author: Aleksander Alekseev <aleksander@tigerdata.com>
Discussion: https://postgr.es/m/CAJ7c6TMSF7cANU8nEJ9E28EvU74tE4H7AzT292Rt3ZuHqqxq8w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e2a8cabc47f9502d26b1212851b6d43e5c06df22

Modified Files
--------------
src/backend/commands/repack.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)



Message-ID: <E1wZSuF-000Z3a-2D@gemulon.postgresql.org>
Permalink:  ../E1wZSuF-000Z3a-2D@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wZSuF-000Z3a-2D@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@kurilemu.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: concurrent repack: check there are no leftover toast attribs
  In-Reply-To: <E1wZSuF-000Z3a-2D@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox