agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tatsuo Ishii <ishii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix to not allow null treatment to non window functions.
Date: Wed, 17 Jun 2026 01:14:50 +0000
Message-ID: <E1wZeri-000eUT-0B@gemulon.postgresql.org> (raw)
Fix to not allow null treatment to non window functions.
The null treatment clause (RESPECT NULLS/IGNORE NULLS) are only
allowed to window functions per spec. Previously the check was only
applied to aggregates in window clause. Other types of functions were
allowed to use the clause, which was plain wrong.
To fix this, ParseFuncOrColumn() now checks whether other than window
functions are used with the null treatment clause. If so, error out.
Also remove the unnecessary test for "aggregate functions do not
accept RESPECT/IGNORE NULLS" because it is now checked in the
early-stage new check. The window regression test expected file is
changed accordingly.
Reported-by: jian he <jian.universality@gmail.com>
Reviewed-by: jian he <jian.universality@gmail.com>
Author: Tatsuo Ishii <ishii@postgresql.org>
Discussion: https://postgr.es/m/CACJufxFnm%2BAj2Jyhyd58PtW8e1vTZDKimkZE%2BMashCPSDKw56Q%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4e5920e6de87dc1ed761d2a898b7786c50c11db2
Modified Files
--------------
src/backend/parser/parse_func.c | 16 +++++++++-------
src/test/regress/expected/window.out | 4 ++--
2 files changed, 11 insertions(+), 9 deletions(-)
Message-ID: <E1wZeri-000eUT-0B@gemulon.postgresql.org>
Permalink: ../E1wZeri-000eUT-0B@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wZeri-000eUT-0B@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: ishii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix to not allow null treatment to non window functions.
In-Reply-To: <E1wZeri-000eUT-0B@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox