agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: jsonb_plperl, jsonb_plpython: Fix unguarded recursion and loops.
Date: Wed, 17 Jun 2026 15:04:56 +0000
Message-ID: <E1wZrp2-000jax-0B@gemulon.postgresql.org> (raw)
jsonb_plperl, jsonb_plpython: Fix unguarded recursion and loops.
Add check_stack_depth() to Jsonb_to_SV, SV_to_JsonbValue,
PLyObject_FromJsonbContainer, and PLyObject_ToJsonbValue. Without
this, deeply nested JSONB values can crash the backend with SIGSEGV
instead of raising a proper error.
Also add CHECK_FOR_INTERRUPTS() to the while loop in SV_to_JsonbValue
that dereferences chains of Perl references, so that a circular
reference (e.g. $x = \$x) can be cancelled by the user instead of
spinning indefinitely. (We looked at detecting such circular
references, but it seems more trouble than it's worth.)
Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAJ7c6TPbjkzUk4qJ5dHvDNEz0hBuFue3A-XWz_=897z+BC+z8A@mail.gmail.com
Backpatch-through: 14
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/da82fbb8f9a3b1e46b55d5975ef59113cd3a59a6
Modified Files
--------------
contrib/jsonb_plperl/jsonb_plperl.c | 15 +++++++++++++++
contrib/jsonb_plpython/jsonb_plpython.c | 7 +++++++
2 files changed, 22 insertions(+)
view thread (6+ messages) latest in thread
Message-ID: <E1wZrp2-000jax-0B@gemulon.postgresql.org>
Permalink: ../E1wZrp2-000jax-0B@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wZrp2-000jax-0B@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: jsonb_plperl, jsonb_plpython: Fix unguarded recursion and loops.
In-Reply-To: <E1wZrp2-000jax-0B@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox