agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid errors during ALTER SUBSCRIPTION.
Date: Wed, 17 Jun 2026 22:52:26 +0000
Message-ID: <E1wZz7R-000mIh-37@gemulon.postgresql.org> (raw)
Avoid errors during ALTER SUBSCRIPTION.
Previously, when retrieving the old Subscription object, constructing
the conninfo could encounter an error during
ForeignServerConnectionString(). ACL errors were handled properly, but
other errors could interfere with a user fixing the problem with ALTER
SUBSCRIPTION.
Reported-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/D908370F-2695-4231-851D-17179A6A6F2A@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e5c40584a712e8f8c6bd9a7a87bdb855cfd2f20b
Modified Files
--------------
src/backend/catalog/pg_subscription.c | 72 +++++++++++--------
src/backend/commands/subscriptioncmds.c | 111 +++++++++++++++++++++--------
src/backend/replication/logical/worker.c | 4 +-
src/include/catalog/pg_subscription.h | 3 +-
src/test/regress/expected/subscription.out | 29 ++++++--
src/test/regress/regress.c | 3 +
src/test/regress/sql/subscription.sql | 35 +++++++--
7 files changed, 184 insertions(+), 73 deletions(-)
Message-ID: <E1wZz7R-000mIh-37@gemulon.postgresql.org>
Permalink: ../E1wZz7R-000mIh-37@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wZz7R-000mIh-37@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid errors during ALTER SUBSCRIPTION.
In-Reply-To: <E1wZz7R-000mIh-37@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox