agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding
Date: Thu, 18 Jun 2026 16:23:27 +0000
Message-ID: <E1waFWZ-000tKT-1t@gemulon.postgresql.org> (raw)
hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding loop.
Add CHECK_FOR_INTERRUPTS() to the while loop in plperl_to_hstore()
that dereferences chains of Perl references, so that a circular
reference (e.g. $x = \$x) can be cancelled by the user instead of
spinning indefinitely. (We looked at detecting such circular
references, but it seems more trouble than it's worth.)
This is a follow-up to da82fbb8f, which fixed the same issue in
SV_to_JsonbValue() in jsonb_plperl.
Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAJ7c6TPbjkzUk4qJ5dHvDNEz0hBuFue3A-XWz_=897z+BC+z8A@mail.gmail.com
Backpatch-through: 14
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/4efef9d18e637f5d1e9e09129785d73f5f8619b4
Modified Files
--------------
contrib/hstore_plperl/hstore_plperl.c | 9 +++++++++
1 file changed, 9 insertions(+)
view thread (6+ messages) latest in thread
Message-ID: <E1waFWZ-000tKT-1t@gemulon.postgresql.org>
Permalink: ../E1waFWZ-000tKT-1t@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1waFWZ-000tKT-1t@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding
In-Reply-To: <E1waFWZ-000tKT-1t@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox