agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding
6+ messages / 1 participants
[nested] [flat]

* pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding
@ 2026-06-18 16:23  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2026-06-18 16:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding loop.

Add CHECK_FOR_INTERRUPTS() to the while loop in plperl_to_hstore()
that dereferences chains of Perl references, so that a circular
reference (e.g. $x = \$x) can be cancelled by the user instead of
spinning indefinitely.  (We looked at detecting such circular
references, but it seems more trouble than it's worth.)

This is a follow-up to da82fbb8f, which fixed the same issue in
SV_to_JsonbValue() in jsonb_plperl.

Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAJ7c6TPbjkzUk4qJ5dHvDNEz0hBuFue3A-XWz_=897z+BC+z8A@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1f6b2295f95263a5e5767fb4af6440153a7f02af

Modified Files
--------------
contrib/hstore_plperl/hstore_plperl.c | 9 +++++++++
1 file changed, 9 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding
@ 2026-06-18 16:23  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2026-06-18 16:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding loop.

Add CHECK_FOR_INTERRUPTS() to the while loop in plperl_to_hstore()
that dereferences chains of Perl references, so that a circular
reference (e.g. $x = \$x) can be cancelled by the user instead of
spinning indefinitely.  (We looked at detecting such circular
references, but it seems more trouble than it's worth.)

This is a follow-up to da82fbb8f, which fixed the same issue in
SV_to_JsonbValue() in jsonb_plperl.

Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAJ7c6TPbjkzUk4qJ5dHvDNEz0hBuFue3A-XWz_=897z+BC+z8A@mail.gmail.com
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c0f17b04d9069cdfd0631b86c776be13192dbe1d

Modified Files
--------------
contrib/hstore_plperl/hstore_plperl.c | 9 +++++++++
1 file changed, 9 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding
@ 2026-06-18 16:23  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2026-06-18 16:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding loop.

Add CHECK_FOR_INTERRUPTS() to the while loop in plperl_to_hstore()
that dereferences chains of Perl references, so that a circular
reference (e.g. $x = \$x) can be cancelled by the user instead of
spinning indefinitely.  (We looked at detecting such circular
references, but it seems more trouble than it's worth.)

This is a follow-up to da82fbb8f, which fixed the same issue in
SV_to_JsonbValue() in jsonb_plperl.

Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAJ7c6TPbjkzUk4qJ5dHvDNEz0hBuFue3A-XWz_=897z+BC+z8A@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d65cf6f800f00a560cd479b426a17f73dd0020f7

Modified Files
--------------
contrib/hstore_plperl/hstore_plperl.c | 9 +++++++++
1 file changed, 9 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding
@ 2026-06-18 16:23  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2026-06-18 16:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding loop.

Add CHECK_FOR_INTERRUPTS() to the while loop in plperl_to_hstore()
that dereferences chains of Perl references, so that a circular
reference (e.g. $x = \$x) can be cancelled by the user instead of
spinning indefinitely.  (We looked at detecting such circular
references, but it seems more trouble than it's worth.)

This is a follow-up to da82fbb8f, which fixed the same issue in
SV_to_JsonbValue() in jsonb_plperl.

Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAJ7c6TPbjkzUk4qJ5dHvDNEz0hBuFue3A-XWz_=897z+BC+z8A@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4efef9d18e637f5d1e9e09129785d73f5f8619b4

Modified Files
--------------
contrib/hstore_plperl/hstore_plperl.c | 9 +++++++++
1 file changed, 9 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding
@ 2026-06-18 16:23  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2026-06-18 16:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding loop.

Add CHECK_FOR_INTERRUPTS() to the while loop in plperl_to_hstore()
that dereferences chains of Perl references, so that a circular
reference (e.g. $x = \$x) can be cancelled by the user instead of
spinning indefinitely.  (We looked at detecting such circular
references, but it seems more trouble than it's worth.)

This is a follow-up to da82fbb8f, which fixed the same issue in
SV_to_JsonbValue() in jsonb_plperl.

Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAJ7c6TPbjkzUk4qJ5dHvDNEz0hBuFue3A-XWz_=897z+BC+z8A@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/60a1d712a4726fdb44842fd06168715d8534b403

Modified Files
--------------
contrib/hstore_plperl/hstore_plperl.c | 9 +++++++++
1 file changed, 9 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding
@ 2026-06-18 16:23  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2026-06-18 16:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding loop.

Add CHECK_FOR_INTERRUPTS() to the while loop in plperl_to_hstore()
that dereferences chains of Perl references, so that a circular
reference (e.g. $x = \$x) can be cancelled by the user instead of
spinning indefinitely.  (We looked at detecting such circular
references, but it seems more trouble than it's worth.)

This is a follow-up to da82fbb8f, which fixed the same issue in
SV_to_JsonbValue() in jsonb_plperl.

Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAJ7c6TPbjkzUk4qJ5dHvDNEz0hBuFue3A-XWz_=897z+BC+z8A@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4fbbabb0a729d643fcc3494f9c22cc700570c143

Modified Files
--------------
contrib/hstore_plperl/hstore_plperl.c | 9 +++++++++
1 file changed, 9 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2026-06-18 16:23 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-06-18 16:23 pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding Tom Lane <tgl@sss.pgh.pa.us>
2026-06-18 16:23 pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding Tom Lane <tgl@sss.pgh.pa.us>
2026-06-18 16:23 pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding Tom Lane <tgl@sss.pgh.pa.us>
2026-06-18 16:23 pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding Tom Lane <tgl@sss.pgh.pa.us>
2026-06-18 16:23 pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding Tom Lane <tgl@sss.pgh.pa.us>
2026-06-18 16:23 pgsql: hstore_plperl: Add CHECK_FOR_INTERRUPTS() in reference-unwinding Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox