agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix comments on data checksum cost settings
Date: Thu, 18 Jun 2026 21:22:26 +0000
Message-ID: <E1waKBt-000uuI-2q@gemulon.postgresql.org> (raw)
Fix comments on data checksum cost settings
The cost parameters for the data checksums worker can be updated by the
user issuing a repeated enable checksum command, but the comments on the
struct members hadn't been updated to reflect this and were out of date.
Another part of the same comment needed better wording to be readable.
Also wrap the reading of the parameters in a lock, there is no live
bug due to not using a lock but it's still the right thing to do.
Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reported-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/2176020b-ecbc-438b-9fc3-9c3593d9e6fc@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8d22f5232458278aa62a1769758a8aa6b1dfe290
Modified Files
--------------
src/backend/postmaster/datachecksum_state.c | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
Message-ID: <E1waKBt-000uuI-2q@gemulon.postgresql.org>
Permalink: ../E1waKBt-000uuI-2q@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1waKBt-000uuI-2q@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix comments on data checksum cost settings
In-Reply-To: <E1waKBt-000uuI-2q@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox