agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Misc cleanup in datachecksums_state.[ch]
Date: Wed, 24 Jun 2026 12:39:39 +0000
Message-ID: <E1wcMtH-0001eo-16@gemulon.postgresql.org> (raw)
Misc cleanup in datachecksums_state.[ch]
Move DataChecksumsWorkerResult struct to the .c file. It's not used
anywhere else since commit 07009121c2 removed the injection point test
code that the comment referred to.
Mark StartDataChecksumsWorkerLauncher() as static, since it's not
called from outside the .c file. The DataChecksumsWorkerOperation
struct can then be moved into the .c file too.
Clarify the comment on StartDataChecksumsWorkerLauncher(). It said
"Main entry point for datachecksumsworker launcher process", but I
found that misleading. That description would be a better fit for
DataChecksumsWorkerLauncherMain(), which is the process's "main"
function, rather than StartDataChecksumsWorkerLauncher().
Fix comment on WaitForAllTransactionsToFinish() on postmaster death.
The comment claimed that it sets "the abort flag" on postmaster death,
but it actually just errors outs. Improve the comment to explain why
it doesn't just use WL_EXIT_ON_PM_DEATH.
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://www.postgresql.org/message-id/b283fbb9-298e-4953-9120-eefaf24fae20@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0edbf72f76833a145cb8eca128b775a8f0090d15
Modified Files
--------------
src/backend/postmaster/datachecksum_state.c | 35 +++++++++++++++++++++--------
src/include/postmaster/datachecksum_state.h | 26 ---------------------
2 files changed, 26 insertions(+), 35 deletions(-)
Message-ID: <E1wcMtH-0001eo-16@gemulon.postgresql.org>
Permalink: ../E1wcMtH-0001eo-16@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wcMtH-0001eo-16@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Misc cleanup in datachecksums_state.[ch]
In-Reply-To: <E1wcMtH-0001eo-16@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox