agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Minor cleanup around checking datachecksum worker result
Date: Wed, 24 Jun 2026 12:39:39 +0000
Message-ID: <E1wcMtH-0001es-1L@gemulon.postgresql.org> (raw)
Minor cleanup around checking datachecksum worker result
Rename the 'success' field in DataChecksumState to 'worker_result'.
That's more appropriate when it's not a simple boolean.
Don't access the field after releasing the lock in ProcessDatabase().
No other process should be modifying it, but if we bother to do any
locking in the first place, let's do it right.
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://www.postgresql.org/message-id/b283fbb9-298e-4953-9120-eefaf24fae20@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c48e7b2c8bd09c3a81658ac2388be28b80b87142
Modified Files
--------------
src/backend/postmaster/datachecksum_state.c | 35 ++++++++++++++++-------------
1 file changed, 19 insertions(+), 16 deletions(-)
Message-ID: <E1wcMtH-0001es-1L@gemulon.postgresql.org>
Permalink: ../E1wcMtH-0001es-1L@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wcMtH-0001es-1L@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Minor cleanup around checking datachecksum worker result
In-Reply-To: <E1wcMtH-0001es-1L@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox