agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix macro-redefinition warning introduced by aeb07c55f.
Date: Wed, 01 Jul 2026 17:44:51 +0000
Message-ID: <E1weyzT-000yyx-2O@gemulon.postgresql.org> (raw)
Fix macro-redefinition warning introduced by aeb07c55f.
Some platforms provide a definition of unreachable() in standard C
headers, leading to a conflict with unreachable() in the new
timezone code. It seems best for our purposes to conform to what
pg_unreachable() does, so #undef away the platform version.
Reported-by: Tristan Partin <tristan@partin.io>
Discussion: https://postgr.es/m/DJNDN9UQS9GP.11L4NJ1HHE1ZJ@partin.io
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/85656c1bef4af031f8e9801d927cdaeaaae95566
Modified Files
--------------
src/timezone/private.h | 2 ++
1 file changed, 2 insertions(+)
Message-ID: <E1weyzT-000yyx-2O@gemulon.postgresql.org>
Permalink: ../E1weyzT-000yyx-2O@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1weyzT-000yyx-2O@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix macro-redefinition warning introduced by aeb07c55f.
In-Reply-To: <E1weyzT-000yyx-2O@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox