agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: test_custom_stats: Fail if loading module outside shared_preload
Date: Thu, 02 Jul 2026 06:53:23 +0000
Message-ID: <E1wfBIa-0013FM-08@gemulon.postgresql.org> (raw)
test_custom_stats: Fail if loading module outside shared_preload_libraries
Previously, test_custom_var_stats and test_custom_fixed_stats silently
skipped pgstat_register_kind() when not loaded via
shared_preload_libraries, behavior inherited from injection_points.
This left the SQL functions callable without the kind registered,
leading to various issues on the backend side.
This code is not designed to work without the pgstats kinds registered.
pgstat_register_kind() gets now called when these libraries are loaded,
with or without shared_preload_libraries, letting the registration fail
if loading the modules at a later step than startup. test_custom_rmgrs
does the same thing.
Oversight in 31280d96a648.
Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Ewan Young <kdbase.hack@gmail.com>
Discussion: https://postgr.es/m/akS/ldidWeqG1FWk@bdtpg
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5045d9ff3b5a8b09742d8bf70221c7d708305219
Modified Files
--------------
src/test/modules/test_custom_stats/test_custom_fixed_stats.c | 4 ----
src/test/modules/test_custom_stats/test_custom_var_stats.c | 4 ----
2 files changed, 8 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wfBIa-0013FM-08@gemulon.postgresql.org>
Permalink: ../E1wfBIa-0013FM-08@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wfBIa-0013FM-08@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: test_custom_stats: Fail if loading module outside shared_preload
In-Reply-To: <E1wfBIa-0013FM-08@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox