agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single
Date: Thu, 02 Jul 2026 20:19:32 +0000
Message-ID: <E1wfNsj-0016dK-0D@gemulon.postgresql.org> (raw)
pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single relation.
A foreign scan can target a single relation while still reaching the
fs_relids branch of pgpa_build_scan() -- for example, when postgres_fdw
pushes an aggregate down over one foreign table. In that case, no
advice should be emitted.
Author: Mahendra Singh Thalor <mahi6run@gmail.com>
Co-authored-by: Robert Haas <rhaas@postgresql.org>
Discussion: http://postgr.es/m/CAKYtNAofuAJBz6++SeikpCb=Y=MO1QgEuZNJ+KZOP2johF1r4Q@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/53e6f51eef55e8e4520901e40b4d143d944358c0
Modified Files
--------------
contrib/pg_plan_advice/Makefile | 4 +-
contrib/pg_plan_advice/meson.build | 5 ++
contrib/pg_plan_advice/pgpa_scan.c | 8 ++-
contrib/pg_plan_advice/t/001_foreign_scan.pl | 83 ++++++++++++++++++++++++++++
4 files changed, 97 insertions(+), 3 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wfNsj-0016dK-0D@gemulon.postgresql.org>
Permalink: ../E1wfNsj-0016dK-0D@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wfNsj-0016dK-0D@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single
In-Reply-To: <E1wfNsj-0016dK-0D@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox