agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
pgsql: pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single
2+ messages / 1 participants
[nested] [flat]

* pgsql: pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single
@ 2026-07-02 20:19 Robert Haas <rhaas@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Robert Haas @ 2026-07-02 20:19 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single relation.

A foreign scan can target a single relation while still reaching the
fs_relids branch of pgpa_build_scan() -- for example, when postgres_fdw
pushes an aggregate down over one foreign table. In that case, no
advice should be emitted.

Author: Mahendra Singh Thalor <mahi6run@gmail.com>
Co-authored-by: Robert Haas <rhaas@postgresql.org>
Discussion: http://postgr.es/m/CAKYtNAofuAJBz6++SeikpCb=Y=MO1QgEuZNJ+KZOP2johF1r4Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/53e6f51eef55e8e4520901e40b4d143d944358c0

Modified Files
--------------
contrib/pg_plan_advice/Makefile              |  4 +-
contrib/pg_plan_advice/meson.build           |  5 ++
contrib/pg_plan_advice/pgpa_scan.c           |  8 ++-
contrib/pg_plan_advice/t/001_foreign_scan.pl | 83 ++++++++++++++++++++++++++++
4 files changed, 97 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single
@ 2026-07-02 20:19 Robert Haas <rhaas@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Robert Haas @ 2026-07-02 20:19 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single relation.

A foreign scan can target a single relation while still reaching the
fs_relids branch of pgpa_build_scan() -- for example, when postgres_fdw
pushes an aggregate down over one foreign table. In that case, no
advice should be emitted.

Author: Mahendra Singh Thalor <mahi6run@gmail.com>
Co-authored-by: Robert Haas <rhaas@postgresql.org>
Discussion: http://postgr.es/m/CAKYtNAofuAJBz6++SeikpCb=Y=MO1QgEuZNJ+KZOP2johF1r4Q@mail.gmail.com

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/89f5f860cc584cf4c531dbc38b614e4db5c61e24

Modified Files
--------------
contrib/pg_plan_advice/Makefile              |  4 +-
contrib/pg_plan_advice/meson.build           |  5 ++
contrib/pg_plan_advice/pgpa_scan.c           |  8 ++-
contrib/pg_plan_advice/t/001_foreign_scan.pl | 83 ++++++++++++++++++++++++++++
4 files changed, 97 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2026-07-02 20:19 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-02 20:19 pgsql: pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single Robert Haas <rhaas@postgresql.org>
2026-07-02 20:19 pgsql: pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single Robert Haas <rhaas@postgresql.org>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox