agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Prevent dropping the last label from a property graph element
Date: Fri, 03 Jul 2026 10:17:50 +0000
Message-ID: <E1wfaxy-0019gh-1H@gemulon.postgresql.org> (raw)

Prevent dropping the last label from a property graph element

Per SQL/PGQ standard, every graph element must have at least one
label.  When dropping a label from a graph element, ensure that there
exists at least one other label on the element.  If the label being
dropped is the only label on the element, raise an error.

We hold a ShareRowExclusiveLock when modifying a property graph.
Hence the label will not be dropped even when multiple labels are
being dropped concurrently.

Author: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Author: Satyanarayana Narlapuram <satyanarlapuram@gmail.com>
Reported-by: Satyanarayana Narlapuram <satyanarlapuram@gmail.com>
Discussion: https://www.postgresql.org/message-id/CAHg+QDeP=mTHTV48R23zKMy1SBmCKZ_L7-z5zKnYyw+K0x-gCg@mail.gmail...

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ac0ad6a7c9d1f7c0d82696260fdcb2d09a8962c1

Modified Files
--------------
doc/src/sgml/ref/alter_property_graph.sgml         |  4 +-
src/backend/commands/propgraphcmds.c               | 55 ++++++++++++++++++++--
.../regress/expected/create_property_graph.out     |  7 +++
src/test/regress/sql/create_property_graph.sql     |  5 ++
4 files changed, 65 insertions(+), 6 deletions(-)



view thread (2+ messages)

Message-ID: <E1wfaxy-0019gh-1H@gemulon.postgresql.org>
Permalink:  ../E1wfaxy-0019gh-1H@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wfaxy-0019gh-1H@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Prevent dropping the last label from a property graph element
  In-Reply-To: <E1wfaxy-0019gh-1H@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox