agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix REPACK CONCURRENTLY for stored generated columns
Date: Fri, 03 Jul 2026 10:23:44 +0000
Message-ID: <E1wfb3g-0019jS-2t@gemulon.postgresql.org> (raw)
Fix REPACK CONCURRENTLY for stored generated columns
In order to replay concurrent changes, REPACK CONCURRENTLY needs the
pg_attrdef tuples for the transient table to be there, in case a tuple
is modified concurrently with REPACK and requires to store the value
from the generated column (which, with the current arrangements, means
all tuples concurrently updated or inserted). Fix by creating a copy of
them from the original table. Add a test that tickles the bug.
Author: Antonin Houska <ah@cybertec.at>
Reported-by: Ewan Young <kdbase.hack@gmail.com>
Diagnosed-by: Ewan Young <kdbase.hack@gmail.com>
Reviewed-by: Ewan Young <kdbase.hack@gmail.com>
Backpatch-through: 19
Discussion: https://postgr.es/m/CAON2xHMrELwx9vKg6niSf8fMBA=-MGXmG=MPQU6+vMVhGjF8kQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3be823486f2c9f405fc754ac0ece3ce412aee105
Modified Files
--------------
src/backend/commands/repack.c | 103 ++++++++++++++++++++-
.../modules/injection_points/specs/repack.spec | 3 +-
2 files changed, 104 insertions(+), 2 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wfb3g-0019jS-2t@gemulon.postgresql.org>
Permalink: ../E1wfb3g-0019jS-2t@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wfb3g-0019jS-2t@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@kurilemu.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix REPACK CONCURRENTLY for stored generated columns
In-Reply-To: <E1wfb3g-0019jS-2t@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox