agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix handling of dropping a property not associated with the give
Date: Fri, 03 Jul 2026 14:39:39 +0000
Message-ID: <E1wff3L-001Azc-0l@gemulon.postgresql.org> (raw)
Fix handling of dropping a property not associated with the given label
When dropping a property by name from a label, the code checked only
whether the property existed in the graph's property catalog. It did
not verify that the property was actually associated with the given
label, resulting in passing InvalidOid to performDeletion(). Fix it
by explicilty checking the label property association.
While at it also rearrange the code so as to avoid multiple ereport
calls for the same error in the same block.
Author: Chao Li <lic@highgo.com>
Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/1DA5D52A-4AFA-426E-83F7-42ED974D682B%40gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/96418a6da9d0e120c30f9b6c2c2bd8bbb0a98d00
Modified Files
--------------
src/backend/commands/propgraphcmds.c | 47 +++++++++-------------
.../regress/expected/create_property_graph.out | 2 +
src/test/regress/sql/create_property_graph.sql | 1 +
3 files changed, 22 insertions(+), 28 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wff3L-001Azc-0l@gemulon.postgresql.org>
Permalink: ../E1wff3L-001Azc-0l@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wff3L-001Azc-0l@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix handling of dropping a property not associated with the give
In-Reply-To: <E1wff3L-001Azc-0l@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox