agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Fix handling of dropping a property not associated with the give 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix handling of dropping a property not associated with the give @ 2026-07-03 14:39 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2026-07-03 14:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix handling of dropping a property not associated with the given label When dropping a property by name from a label, the code checked only whether the property existed in the graph's property catalog. It did not verify that the property was actually associated with the given label, resulting in passing InvalidOid to performDeletion(). Fix it by explicilty checking the label property association. While at it also rearrange the code so as to avoid multiple ereport calls for the same error in the same block. Author: Chao Li <lic@highgo.com> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/1DA5D52A-4AFA-426E-83F7-42ED974D682B%40gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/96418a6da9d0e120c30f9b6c2c2bd8bbb0a98d00 Modified Files -------------- src/backend/commands/propgraphcmds.c | 47 +++++++++------------- .../regress/expected/create_property_graph.out | 2 + src/test/regress/sql/create_property_graph.sql | 1 + 3 files changed, 22 insertions(+), 28 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix handling of dropping a property not associated with the give @ 2026-07-03 14:39 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2026-07-03 14:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix handling of dropping a property not associated with the given label When dropping a property by name from a label, the code checked only whether the property existed in the graph's property catalog. It did not verify that the property was actually associated with the given label, resulting in passing InvalidOid to performDeletion(). Fix it by explicilty checking the label property association. While at it also rearrange the code so as to avoid multiple ereport calls for the same error in the same block. Author: Chao Li <lic@highgo.com> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/1DA5D52A-4AFA-426E-83F7-42ED974D682B%40gmail.com Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/36aae3d0297d35602dec40ca3edbaf82320a4cc7 Modified Files -------------- src/backend/commands/propgraphcmds.c | 47 +++++++++------------- .../regress/expected/create_property_graph.out | 2 + src/test/regress/sql/create_property_graph.sql | 1 + 3 files changed, 22 insertions(+), 28 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-07-03 14:39 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-07-03 14:39 pgsql: Fix handling of dropping a property not associated with the give Peter Eisentraut <peter@eisentraut.org> 2026-07-03 14:39 pgsql: Fix handling of dropping a property not associated with the give Peter Eisentraut <peter@eisentraut.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox