agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: REPACK CONCURRENTLY: Initialize the range table more honestly
Date: Fri, 03 Jul 2026 18:06:14 +0000
Message-ID: <E1wfiHG-001CSU-1h@gemulon.postgresql.org> (raw)
REPACK CONCURRENTLY: Initialize the range table more honestly
We were skipping a bunch of things that are mostly unnecessary for
REPACK. However, one thing that seems would be better to pass closer to
truth, is the updatedCols bitmapset in the range table entry for the
repacked table. Cons up an RTE and install it into the EState.
This only has an effect on btree indexes, because certain operations are
optimized in the case of unchanged columns; and even then, correctnesss
is not being compromised.
The values we pass after this commit are not fully trustworthy either,
because we simply say "all columns were updated" for all insert/updates,
regardless of whether their values were actually modified or not.
However, this way we err to the side of caution rather than to the
opposite direction as we were originally doing. This could be refined
in the future, but there's a trade-off: determining whether the column
was in fact updated could be expensive.
Author: Antonin Houska <ah@cybertec.at>
Reviewed-by: Ewan Young <kdbase.hack@gmail.com>
Backpatch-through: 19
Discussion: https://postgr.es/m/18222.1782126731@localhost
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5e450df50dc8e688abbad229f174f006cc550388
Modified Files
--------------
src/backend/commands/repack.c | 57 +++++++++++++++++++++++++++++++++++++++++--
1 file changed, 55 insertions(+), 2 deletions(-)
view thread (2+ messages)
Message-ID: <E1wfiHG-001CSU-1h@gemulon.postgresql.org>
Permalink: ../E1wfiHG-001CSU-1h@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wfiHG-001CSU-1h@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@kurilemu.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: REPACK CONCURRENTLY: Initialize the range table more honestly
In-Reply-To: <E1wfiHG-001CSU-1h@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox