agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Restore basebackup_progress_done() to preserve ABI 4+ messages / 1 participants [nested] [flat]
* pgsql: Restore basebackup_progress_done() to preserve ABI @ 2026-07-06 00:48 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Fujii Masao @ 2026-07-06 00:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restore basebackup_progress_done() to preserve ABI Commit e7564ee8cdc, which fixed base backup progress reporting on backup failure, removed the external function basebackup_progress_done() because it was no longer used in core. When that change was backpatched to v15, it introduced an ABI break, which was reported by buildfarm member crake. This commit restores basebackup_progress_done() to preserve ABI compatibility, even though it is no longer used in core, rather than updating the .abi-compliance-history file. Because external backup tools may still call this function. Per buildfarm member crake. Reported-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/CAD5tBcJ+ktrEp=PT8Gq-f=8mA2cDtZMB-hDMV4mMJ+9V46qBeQ@mail.gmail.com Backpatch-through: 15-18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e2ad214dd80adbe905253b5689db4bf6e0ce7788 Modified Files -------------- src/backend/backup/basebackup_progress.c | 12 ++++++++++++ src/include/backup/basebackup_sink.h | 1 + 2 files changed, 13 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Restore basebackup_progress_done() to preserve ABI @ 2026-07-06 00:48 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Fujii Masao @ 2026-07-06 00:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restore basebackup_progress_done() to preserve ABI Commit e7564ee8cdc, which fixed base backup progress reporting on backup failure, removed the external function basebackup_progress_done() because it was no longer used in core. When that change was backpatched to v15, it introduced an ABI break, which was reported by buildfarm member crake. This commit restores basebackup_progress_done() to preserve ABI compatibility, even though it is no longer used in core, rather than updating the .abi-compliance-history file. Because external backup tools may still call this function. Per buildfarm member crake. Reported-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/CAD5tBcJ+ktrEp=PT8Gq-f=8mA2cDtZMB-hDMV4mMJ+9V46qBeQ@mail.gmail.com Backpatch-through: 15-18 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a240e8cd23532931ca1e5216f4f42e91fac36dfe Modified Files -------------- src/backend/backup/basebackup_progress.c | 12 ++++++++++++ src/include/backup/basebackup_sink.h | 1 + 2 files changed, 13 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Restore basebackup_progress_done() to preserve ABI @ 2026-07-06 00:48 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Fujii Masao @ 2026-07-06 00:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restore basebackup_progress_done() to preserve ABI Commit e7564ee8cdc, which fixed base backup progress reporting on backup failure, removed the external function basebackup_progress_done() because it was no longer used in core. When that change was backpatched to v15, it introduced an ABI break, which was reported by buildfarm member crake. This commit restores basebackup_progress_done() to preserve ABI compatibility, even though it is no longer used in core, rather than updating the .abi-compliance-history file. Because external backup tools may still call this function. Per buildfarm member crake. Reported-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/CAD5tBcJ+ktrEp=PT8Gq-f=8mA2cDtZMB-hDMV4mMJ+9V46qBeQ@mail.gmail.com Backpatch-through: 15-18 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fffa4d870b70a30ccd799a71689cd2ece183c30c Modified Files -------------- src/backend/backup/basebackup_progress.c | 12 ++++++++++++ src/include/backup/basebackup_sink.h | 1 + 2 files changed, 13 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Restore basebackup_progress_done() to preserve ABI @ 2026-07-06 00:49 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Fujii Masao @ 2026-07-06 00:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restore basebackup_progress_done() to preserve ABI Commit e7564ee8cdc, which fixed base backup progress reporting on backup failure, removed the external function basebackup_progress_done() because it was no longer used in core. When that change was backpatched to v15, it introduced an ABI break, which was reported by buildfarm member crake. This commit restores basebackup_progress_done() to preserve ABI compatibility, even though it is no longer used in core, rather than updating the .abi-compliance-history file. Because external backup tools may still call this function. Per buildfarm member crake. Reported-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/CAD5tBcJ+ktrEp=PT8Gq-f=8mA2cDtZMB-hDMV4mMJ+9V46qBeQ@mail.gmail.com Backpatch-through: 15-18 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a8fb98b7bfe5af3be68767c1ab7a988f2e17fd32 Modified Files -------------- src/backend/backup/basebackup_progress.c | 12 ++++++++++++ src/include/backup/basebackup_sink.h | 1 + 2 files changed, 13 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2026-07-06 00:49 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-07-06 00:48 pgsql: Restore basebackup_progress_done() to preserve ABI Fujii Masao <fujii@postgresql.org> 2026-07-06 00:48 pgsql: Restore basebackup_progress_done() to preserve ABI Fujii Masao <fujii@postgresql.org> 2026-07-06 00:48 pgsql: Restore basebackup_progress_done() to preserve ABI Fujii Masao <fujii@postgresql.org> 2026-07-06 00:49 pgsql: Restore basebackup_progress_done() to preserve ABI Fujii Masao <fujii@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox