agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Restore basebackup_progress_done() to preserve ABI
Date: Mon, 06 Jul 2026 00:48:58 +0000
Message-ID: <E1wgXW6-001Vzm-0i@gemulon.postgresql.org> (raw)
Restore basebackup_progress_done() to preserve ABI
Commit e7564ee8cdc, which fixed base backup progress reporting on
backup failure, removed the external function basebackup_progress_done()
because it was no longer used in core. When that change was backpatched
to v15, it introduced an ABI break, which was reported by buildfarm
member crake.
This commit restores basebackup_progress_done() to preserve ABI
compatibility, even though it is no longer used in core, rather than
updating the .abi-compliance-history file. Because external backup
tools may still call this function.
Per buildfarm member crake.
Reported-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/CAD5tBcJ+ktrEp=PT8Gq-f=8mA2cDtZMB-hDMV4mMJ+9V46qBeQ@mail.gmail.com
Backpatch-through: 15-18
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/fffa4d870b70a30ccd799a71689cd2ece183c30c
Modified Files
--------------
src/backend/backup/basebackup_progress.c | 12 ++++++++++++
src/include/backup/basebackup_sink.h | 1 +
2 files changed, 13 insertions(+)
view thread (4+ messages) latest in thread
Message-ID: <E1wgXW6-001Vzm-0i@gemulon.postgresql.org>
Permalink: ../E1wgXW6-001Vzm-0i@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wgXW6-001Vzm-0i@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Restore basebackup_progress_done() to preserve ABI
In-Reply-To: <E1wgXW6-001Vzm-0i@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox