pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Print off_t/pgoff_t consistently as %lld
Date: Tue, 07 Jul 2026 09:56:16 +0000
Message-ID: <E1wh2XI-0000g9-2v@gemulon.postgresql.org> (raw)

Print off_t/pgoff_t consistently as %lld

This was the dominant style already, but some places used %llu
instead.  Since off_t/pgoff_t are signed types, using %lld seems a
better match, and it might handle obscure error conditions with
negative values better.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c22d2f7fd46c692c83152773387be6b731c1a4b9

Modified Files
--------------
src/bin/pg_combinebackup/reconstruct.c     | 10 +++++-----
src/bin/pg_dump/pg_backup_tar.c            |  8 ++++----
src/bin/pg_rewind/libpq_source.c           |  2 +-
src/bin/pg_verifybackup/astreamer_verify.c |  4 ++--
src/bin/pg_verifybackup/pg_verifybackup.c  |  6 +++---
5 files changed, 15 insertions(+), 15 deletions(-)



Message-ID: <E1wh2XI-0000g9-2v@gemulon.postgresql.org>
Permalink:  ../E1wh2XI-0000g9-2v@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wh2XI-0000g9-2v@gemulon.postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Print off_t/pgoff_t consistently as %lld
  In-Reply-To: <E1wh2XI-0000g9-2v@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox