agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Etsuro Fujita <efujita@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: postgres_fdw: Remove SPI from postgresImportForeignStatistics.
Date: Fri, 10 Jul 2026 04:22:04 +0000
Message-ID: <E1wi2kV-000OaU-1y@gemulon.postgresql.org> (raw)
postgres_fdw: Remove SPI from postgresImportForeignStatistics.
Previously, this function imported remote statistics by executing SQL
functions like pg_restore_relation_stats and pg_restore_attribute_stats
via SPI (in read-write mode). As the SQL functions take a schema name
and a relation name as two separate arguments, rather than a single OID
argument, if the containing schema was concurrently renamed, the
callback function would throw an error like this:
ERROR: schema "foo" does not exist
To fix, 1) provide new interface functions to import remote statistics
that are directly callable from FDWs and take a single OID, and 2)
modify the callback function to use the interface functions instead when
importing remote statistics.
For #1, this commit does a bit of refactoring to
relation_statistics_update and attribute_statistics_update, which are
the workhorse functions for pg_restore_relation_stats and
pg_restore_attribute_stats respectively: since they also take a schema
name and a relation name, separate the guts of them into new functions
so that they take a single OID and are callable not only from the
workhorse functions but from the interface functions introduced by #1.
Oversight in commit 28972b6fc.
Reported-by: Robert Haas <robertmhaas@gmail.com>
Suggested-by: Robert Haas <robertmhaas@gmail.com>
Author: Corey Huinker <corey.huinker@gmail.com>
Co-authored-by: Etsuro Fujita <etsuro.fujita@gmail.com>
Discussion: https://postgr.es/m/CA%2BTgmoYqMtWb4zLUkT98oFnEkJ%3DWz0Pw-ggDJrp9wnSXPzUaeQ%40mail.gmail.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/54cd6fc83176d7c03abf95554aef26b0b24acc7d
Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 37 +++
contrib/postgres_fdw/postgres_fdw.c | 443 ++++++++++---------------
contrib/postgres_fdw/sql/postgres_fdw.sql | 28 ++
doc/src/sgml/fdwhandler.sgml | 5 +-
src/backend/statistics/attribute_stats.c | 174 ++++++++--
src/backend/statistics/relation_stats.c | 86 ++++-
src/include/statistics/statistics.h | 25 ++
7 files changed, 484 insertions(+), 314 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wi2kV-000OaU-1y@gemulon.postgresql.org>
Permalink: ../E1wi2kV-000OaU-1y@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wi2kV-000OaU-1y@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: efujita@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: postgres_fdw: Remove SPI from postgresImportForeignStatistics.
In-Reply-To: <E1wi2kV-000OaU-1y@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox