agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Forbid FOR PORTION OF on views with INSTEAD OF triggers
Date: Fri, 10 Jul 2026 08:20:52 +0000
Message-ID: <E1wi6Tb-000Q6X-1q@gemulon.postgresql.org> (raw)

Forbid FOR PORTION OF on views with INSTEAD OF triggers

Previously, an attempt to use these features together caused a crash.
Oversight of commit 8e72d914c528.

Tests are added also to show that the check for this should be in the
rewriter, not the parser, as an earlier patch version suggested.

Author: Aleksander Alekseev <aleksander@tigerdata.com>
Author: Paul A. Jungwirth <pj@illuminatedcomputing.com>
Discussion: https://www.postgresql.org/message-id/flat/CAJ7c6TME%2Bix6VRf-2TPnVTsj8qn_hy6sYAOmMhZEivwsu2wS6g%40m...

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5b5e99047ab0df2ef3d18de81176558e49015205

Modified Files
--------------
src/backend/rewrite/rewriteHandler.c          |  8 +++
src/test/regress/expected/updatable_views.out | 71 ++++++++++++++++++++++++++
src/test/regress/sql/updatable_views.sql      | 73 +++++++++++++++++++++++++++
3 files changed, 152 insertions(+)



view thread (2+ messages)

Message-ID: <E1wi6Tb-000Q6X-1q@gemulon.postgresql.org>
Permalink:  ../E1wi6Tb-000Q6X-1q@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wi6Tb-000Q6X-1q@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Forbid FOR PORTION OF on views with INSTEAD OF triggers
  In-Reply-To: <E1wi6Tb-000Q6X-1q@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox