agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Shorten pg_attribute_always_inline to pg_always_inline
Date: Sat, 11 Jul 2026 16:04:53 +0000
Message-ID: <E1wiaCC-000cXx-2W@gemulon.postgresql.org> (raw)
Shorten pg_attribute_always_inline to pg_always_inline
The pg_attribute_always_inline macro name is so long it forces pgindent
to format the code in strange ways. Which may incentivize patch authors
to either structure the code in strange ways (e.g. reorder prototypes),
use shorter names, etc. Neither is very desirable for code readability.
This shortens the name by removing the _attribute_ part. It also makes
it more consistent with pg_noinline, which does not have the _attribute_
part either.
Backpatched to all supported branches, to prevent conflicts when
backpatching other fixes. The backbranches however keep both the old and
new macro name, so that existing code keeps working.
Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Peter Geoghegan <pg@bowt.ie>
Reviewed-by: Tomas Vondra <tomas@vondra.me>
Discussion: https://postgr.es/m/bqqdehahpoa36igpictuqyn2s2mexk3t3ehidh2ffd2slb35e5@rzgksuiszgbg
Backpatch-through: 14
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/494f4f409c0d5866101dc232454e1187d50a84e0
Modified Files
--------------
src/backend/executor/execExprInterp.c | 50 +++++++++++++++++------------------
src/backend/executor/execTuples.c | 6 ++---
src/backend/executor/nodeHashjoin.c | 2 +-
src/backend/utils/cache/catcache.c | 2 +-
src/include/c.h | 9 ++++++-
5 files changed, 38 insertions(+), 31 deletions(-)
view thread (7+ messages) latest in thread
Message-ID: <E1wiaCC-000cXx-2W@gemulon.postgresql.org>
Permalink: ../E1wiaCC-000cXx-2W@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wiaCC-000cXx-2W@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Shorten pg_attribute_always_inline to pg_always_inline
In-Reply-To: <E1wiaCC-000cXx-2W@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox