agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Rename routines for write/read of pgstats file"
Date: Tue, 14 Jul 2026 23:05:34 +0000
Message-ID: <E1wjmBx-000Csc-2L@gemulon.postgresql.org> (raw)
Revert "Rename routines for write/read of pgstats file"
This reverts commit ed823da1289, that has made pgstat_write_chunk() and
pgstat_read_chunk() available for public use. These routines do not
have a symmetric API definition across reads and writes, with the write
part returning a void status, deferring an error detection once all the
stats entries have been processed with an ferror(), and the read part
returning a boolean status.
These routines are just tiny wrappers around fread() and fwrite(), and
extensions can just define they own routines instead of relying on the
same facilities as the core pgstat.c. This commit removes their
declaration from the public headers, to reduce the confusion.
test_custom_stats is updated to use its own read/write routines.
Perhaps something better could be designed in the future; trying to do
so for v19 is not feasable during beta.
Reported-by: Peter Eisentraut <peter@eisentraut.org>
Author: Sami Imseih <samimseih@gmail.com>
Discussion: https://postgr.es/m/a4a8e9af-3eaf-4bbf-9b21-21620f3fc434@eisentraut.org
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/381b3cfe2be02aa114ef7a28c4ec24feaf377c63
Modified Files
--------------
src/backend/utils/activity/pgstat.c | 55 ++++++++++++----------
src/include/utils/pgstat_internal.h | 5 --
.../test_custom_stats/test_custom_var_stats.c | 28 ++++++-----
3 files changed, 46 insertions(+), 42 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wjmBx-000Csc-2L@gemulon.postgresql.org>
Permalink: ../E1wjmBx-000Csc-2L@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wjmBx-000Csc-2L@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Revert "Rename routines for write/read of pgstats file"
In-Reply-To: <E1wjmBx-000Csc-2L@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox