agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Melanie Plageman <melanieplageman@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make VM clear take a RelFileLocator and not fake relcache
Date: Wed, 15 Jul 2026 21:25:51 +0000
Message-ID: <E1wk770-000Lwu-1Z@gemulon.postgresql.org> (raw)

Make VM clear take a RelFileLocator and not fake relcache

This brings it in line with visibilitymap_set(). An upcoming commit will
start reading visibility map buffers with XLogReadBuffer*() functions,
so we no longer require a relation object to pin the visibility map,
allowing us to remove this fake relcache business altogether.

While we're at it, remove a spurious const qualifier from the
RelFileLocator parameter to visibilitymap_set().

Author: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://postgr.es/m/flat/CAAKRu_bn%2Be7F4yPFBgFbnP%2BsyJRKyNK092bjD2LKvZW7O4Svag%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2340fb8f02b28d2fe7f0023d84c3055a38cd5b9e

Modified Files
--------------
contrib/pg_surgery/heap_surgery.c       |  2 +-
src/backend/access/heap/heapam.c        | 16 ++++++++--------
src/backend/access/heap/heapam_xlog.c   | 14 +++++++-------
src/backend/access/heap/pruneheap.c     |  2 +-
src/backend/access/heap/visibilitymap.c |  9 ++++++---
src/include/access/visibilitymap.h      |  4 ++--
6 files changed, 25 insertions(+), 22 deletions(-)



Message-ID: <E1wk770-000Lwu-1Z@gemulon.postgresql.org>
Permalink:  ../E1wk770-000Lwu-1Z@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wk770-000Lwu-1Z@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: melanieplageman@gmail.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Make VM clear take a RelFileLocator and not fake relcache
  In-Reply-To: <E1wk770-000Lwu-1Z@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox