agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Melanie Plageman <melanieplageman@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix VM clear WAL logging by registering VM blocks
Date: Wed, 15 Jul 2026 21:38:05 +0000
Message-ID: <E1wk7Ir-000M44-0A@gemulon.postgresql.org> (raw)
Fix VM clear WAL logging by registering VM blocks
Heap WAL records that clear bits on the visibility map (like inserts and
deletes) did not register the visibility map blocks they modified.
Because the WAL summarizer only records registered blocks, an
incremental backup taken over such operations would omit the changed VM
pages. On restore, the VM would retain stale all-visible/all-frozen
bits, which can cause wrong results from index-only scans and incorrect
relfrozenxid advancement due to vacuum page skipping.
Not registering the VM buffer also meant we never emitted FPIs of VM
pages when clearing bits. A torn VM page won't raise an error because
the VM is read with ZERO_ON_ERROR; with checksums on, it would be
detected and zeroed, but with checksums off, it is accepted as-is and
can lead to data corruption.
Fix this by registering the VM buffer in the WAL record when clearing VM
bits. The VM buffer must now be locked throughout the critical section
that modifies the VM and heap pages and emits the WAL record. This can
slow down operations that clear the VM, since the VM lock is held longer
and VM FPIs may be emitted, but it is required for correctness.
Note that this fix does not repair existing incremental backups.
Author: Melanie Plageman <melanieplageman@gmail.com>
Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru>
Discussion: https://postgr.es/m/flat/CAAKRu_bn%2Be7F4yPFBgFbnP%2BsyJRKyNK092bjD2LKvZW7O4Svag;
Backpatch-through: 17
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f581fa729d8e108fef853c3156267b1f753d0210
Modified Files
--------------
contrib/pg_surgery/heap_surgery.c | 40 +++-
src/backend/access/heap/heapam.c | 397 ++++++++++++++++++++++++++------
src/backend/access/heap/heapam_xlog.c | 252 ++++++++++++++------
src/backend/access/heap/visibilitymap.c | 34 ++-
src/bin/pg_walsummary/t/002_blocks.pl | 7 +-
src/include/access/heapam_xlog.h | 18 +-
src/include/access/visibilitymap.h | 2 +
7 files changed, 595 insertions(+), 155 deletions(-)
view thread (4+ messages) latest in thread
Message-ID: <E1wk7Ir-000M44-0A@gemulon.postgresql.org>
Permalink: ../E1wk7Ir-000M44-0A@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wk7Ir-000M44-0A@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: melanieplageman@gmail.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix VM clear WAL logging by registering VM blocks
In-Reply-To: <E1wk7Ir-000M44-0A@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox