agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: In transformIndexStmt, transform index expressions in INCLUDING.
Date: Thu, 16 Jul 2026 15:56:19 +0000
Message-ID: <E1wkORe-000TzC-1I@gemulon.postgresql.org> (raw)
In transformIndexStmt, transform index expressions in INCLUDING.
Process these just like the adjacent loop for expressions in regular
index columns. This logic was originally omitted because there was
no intention of supporting index expressions in INCLUDING.
There's still no near-term intention of that, but without this change
the ChooseIndexExpressionName code added by 181b6185c spits up on
expressions in INCLUDING: that expects to handle parse-transformed
expressions, and it runs before we reach the place that is currently
supposed to throw the "not supported" error. We could fix this
problem in other ways, but this way avoids contorting the logic,
and it results in less code to be revised not more if we ever get
around to supporting INCLUDING expressions.
Reported-by: Maaz Syed Adeeb <maaz.adeeb@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Test-authored-by: Maaz Syed Adeeb <maaz.adeeb@gmail.com>
Discussion: https://postgr.es/m/CAG+FJqOxYj=sVyHcys64h9DbvzP6EUPGHJ7oKj-PW=Qp5Ebk_g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/637aa273e6335c2e4d196f510d6787210403ed24
Modified Files
--------------
src/backend/parser/parse_utilcmd.c | 20 ++++++++++++++++++++
src/test/regress/expected/index_including.out | 14 ++++++++++++++
src/test/regress/sql/index_including.sql | 9 +++++++++
3 files changed, 43 insertions(+)
Message-ID: <E1wkORe-000TzC-1I@gemulon.postgresql.org>
Permalink: ../E1wkORe-000TzC-1I@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wkORe-000TzC-1I@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: In transformIndexStmt, transform index expressions in INCLUDING.
In-Reply-To: <E1wkORe-000TzC-1I@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox