agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix truncation rules for base64 encoding
Date: Fri, 17 Jul 2026 13:46:06 +0000
Message-ID: <E1wkitB-000d6C-0q@gemulon.postgresql.org> (raw)
Fix truncation rules for base64 encoding
Commit e1d917182 added support for base64url encoding, a base64 variant
intended to be safe for usage in URLs and filenames. The padding rules
for base64url and base64 differ in that base64url require no extra '='
padding, but the commit unintentionally relaxed this requirement for
base64 as well. Fix by making sure that the truncation logic check
for the encoding and add a test to make sure.
Backpatch down to v19 where support for base64url was introduced.
Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: David E. Wheeler <david@justatheory.com>
Discussion: https://postgr.es/m/3258FC72-F5E1-40B9-B5D7-64478CAF7728@yesql.se
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5f57f58179bf48805558ac0494851e93fe0eca76
Modified Files
--------------
src/backend/utils/adt/encode.c | 4 ++--
src/test/regress/expected/strings.out | 4 ++++
src/test/regress/sql/strings.sql | 3 +++
3 files changed, 9 insertions(+), 2 deletions(-)
view thread (2+ messages)
Message-ID: <E1wkitB-000d6C-0q@gemulon.postgresql.org>
Permalink: ../E1wkitB-000d6C-0q@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wkitB-000d6C-0q@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix truncation rules for base64 encoding
In-Reply-To: <E1wkitB-000d6C-0q@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox