agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Melanie Plageman <melanieplageman@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Turn visibilitymap_clear() Assert back into an error
Date: Fri, 17 Jul 2026 20:50:22 +0000
Message-ID: <E1wkpVm-000fxc-09@gemulon.postgresql.org> (raw)
Turn visibilitymap_clear() Assert back into an error
Commit ed62d26caca fixed a bug in clearing the visibility map and, while
doing so, made some incidental changes to visibilitymap_clear(). One of
them replaced the error thrown when the wrong buffer is passed to
visibilitymap_clear() with an Assert().
While anyone adding a new visibilitymap_clear() caller should be running
assert-enabled builds, visibilitymap_set() still reports the same
wrong-buffer condition with an elog(ERROR), so visibilitymap_clear()
should also do so for consistency. This change was also unrelated to
the bug fix and is better made as a separate commit. Restore the error.
Reported-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwF_PzOv5y7ucFh7Fqqqa8ar83zYwvWugqarRD6%2B7GCtEQ%40mail.gmail.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/3180ce3d7a836e7fbcf8946a0e0be9f263353481
Modified Files
--------------
src/backend/access/heap/visibilitymap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
view thread (2+ messages)
Message-ID: <E1wkpVm-000fxc-09@gemulon.postgresql.org>
Permalink: ../E1wkpVm-000fxc-09@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wkpVm-000fxc-09@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: melanieplageman@gmail.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Turn visibilitymap_clear() Assert back into an error
In-Reply-To: <E1wkpVm-000fxc-09@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox