agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Revert "Reject concurrent sequence refreshes". 2+ messages / 1 participants [nested] [flat]
* pgsql: Revert "Reject concurrent sequence refreshes". @ 2026-07-18 02:33 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2026-07-18 02:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Reject concurrent sequence refreshes". This reverts commit f38afa4abb04e85530c94b88daf11c089375daca. That commit fixed a race that could leave stale sequence values on the subscriber after 'ALTER SUBSCRIPTION ... REFRESH SEQUENCES'. It did so by raising an ERROR during 'ALTER SUBSCRIPTION ... REFRESH SEQUENCES' whenever a sequence synchronization worker was already running for the subscription. That approach caused intermittent buildfarm failures, because the existing tests did not ensure the sequencesync worker had stopped before executing 'ALTER SUBSCRIPTION ... REFRESH SEQUENCES'. While discussing how to fix the tests, we concluded that blocking the command while a sequencesync worker is running is inconvenient for users. So we will fix the original race differently in a follow-up commit. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Author: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 19 Discussion: https://postgr.es/m/3614163.1784163070@sss.pgh.pa.us Discussion: https://postgr.es/m/20260710045217.f0.noahmisch@microsoft.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/dde9a87d4d02a67a5bd459045f03a6f467a00a80 Modified Files -------------- src/backend/commands/subscriptioncmds.c | 27 --------------------------- src/test/subscription/t/036_sequences.pl | 4 ---- 2 files changed, 31 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Revert "Reject concurrent sequence refreshes". @ 2026-07-18 02:33 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2026-07-18 02:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Reject concurrent sequence refreshes". This reverts commit f38afa4abb04e85530c94b88daf11c089375daca. That commit fixed a race that could leave stale sequence values on the subscriber after 'ALTER SUBSCRIPTION ... REFRESH SEQUENCES'. It did so by raising an ERROR during 'ALTER SUBSCRIPTION ... REFRESH SEQUENCES' whenever a sequence synchronization worker was already running for the subscription. That approach caused intermittent buildfarm failures, because the existing tests did not ensure the sequencesync worker had stopped before executing 'ALTER SUBSCRIPTION ... REFRESH SEQUENCES'. While discussing how to fix the tests, we concluded that blocking the command while a sequencesync worker is running is inconvenient for users. So we will fix the original race differently in a follow-up commit. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Author: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 19 Discussion: https://postgr.es/m/3614163.1784163070@sss.pgh.pa.us Discussion: https://postgr.es/m/20260710045217.f0.noahmisch@microsoft.com Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fd27c7e64fe0d5d514ee5fa97250327ce33756fa Modified Files -------------- src/backend/commands/subscriptioncmds.c | 27 --------------------------- src/test/subscription/t/036_sequences.pl | 4 ---- 2 files changed, 31 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-07-18 02:33 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-07-18 02:33 pgsql: Revert "Reject concurrent sequence refreshes". Amit Kapila <akapila@postgresql.org> 2026-07-18 02:33 pgsql: Revert "Reject concurrent sequence refreshes". Amit Kapila <akapila@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox