agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Reject concurrent sequence refreshes".
Date: Sat, 18 Jul 2026 02:33:55 +0000
Message-ID: <E1wkusE-000i9p-1c@gemulon.postgresql.org> (raw)
Revert "Reject concurrent sequence refreshes".
This reverts commit f38afa4abb04e85530c94b88daf11c089375daca.
That commit fixed a race that could leave stale sequence values on the
subscriber after 'ALTER SUBSCRIPTION ... REFRESH SEQUENCES'. It did so by
raising an ERROR during 'ALTER SUBSCRIPTION ... REFRESH SEQUENCES'
whenever a sequence synchronization worker was already running for the
subscription.
That approach caused intermittent buildfarm failures, because the existing
tests did not ensure the sequencesync worker had stopped before executing
'ALTER SUBSCRIPTION ... REFRESH SEQUENCES'. While discussing how to fix
the tests, we concluded that blocking the command while a sequencesync
worker is running is inconvenient for users. So we will fix the original
race differently in a follow-up commit.
Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Author: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 19
Discussion: https://postgr.es/m/3614163.1784163070@sss.pgh.pa.us
Discussion: https://postgr.es/m/20260710045217.f0.noahmisch@microsoft.com
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/fd27c7e64fe0d5d514ee5fa97250327ce33756fa
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 27 ---------------------------
src/test/subscription/t/036_sequences.pl | 4 ----
2 files changed, 31 deletions(-)
view thread (2+ messages)
Message-ID: <E1wkusE-000i9p-1c@gemulon.postgresql.org>
Permalink: ../E1wkusE-000i9p-1c@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wkusE-000i9p-1c@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Revert "Reject concurrent sequence refreshes".
In-Reply-To: <E1wkusE-000i9p-1c@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox