agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix parsing of underscores in pg_plan_advice occurrence numbers
Date: Sun, 19 Jul 2026 21:29:59 +0000
Message-ID: <E1wlZ5E-000Af4-0f@gemulon.postgresql.org> (raw)
Fix parsing of underscores in pg_plan_advice occurrence numbers
The pg_plan_advice scanner recognizes underscores as digit separators
just like the core parser, but used strtoint() to convert occurrence
numbers which does not support underscores. Consequently, advice such
as SEQ_SCAN(x#1_0) failed to parse. Fix by using pg_strtoint32_safe()
like the core scanner, and also add regression test coverage.
This bug was independently found and reported by Lukas Fittl and Chao
Li. Backpatch down to v19 where pg_plan_advice was introduced.
Author: Chao Li <lic@highgo.com>
Co-authored-by: Daniel Gustafsson <daniel@yesql.se>
Reported-by: Lukas Fittl <lukas@fittl.com>
Reported-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Lukas Fittl <lukas@fittl.com>
Discussion: https://postgr.es/m/22E2ECE0-B768-43D5-8575-61C3EBC2E4E8@gmail.com
Discussion: https://postgr.es/m/CAP53PkzKeD=t90OfeMsniYrcRe2THQbUx3g6wV17Y=ZtiwmWTQ@mail.gmail.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f87375bfba5cee2dcea4c19879ee990463be9636
Modified Files
--------------
contrib/pg_plan_advice/expected/syntax.out | 16 ++++++++++++++++
contrib/pg_plan_advice/pgpa_scanner.l | 17 ++++++++++++-----
contrib/pg_plan_advice/sql/syntax.sql | 6 ++++++
3 files changed, 34 insertions(+), 5 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wlZ5E-000Af4-0f@gemulon.postgresql.org>
Permalink: ../E1wlZ5E-000Af4-0f@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wlZ5E-000Af4-0f@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix parsing of underscores in pg_plan_advice occurrence numbers
In-Reply-To: <E1wlZ5E-000Af4-0f@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox